tas/Codewalkers
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Remove agent:output from general SSE subscriptions to prevent listener leak

Browse Source 
agent:output is high-frequency streaming data that was included in
ALL_EVENT_TYPES and AGENT_EVENT_TYPES, causing every onEvent/onAgentUpdate
SSE subscription to register a listener. With multiple subscriptions per
browser tab plus reconnections, this exceeded the 100 listener limit.

The dedicated onAgentOutput subscription handles output streaming already.
Bonus: stops useLiveUpdates from refetching listAgents on every output chunk.
This commit is contained in:
Lukas May
2026-03-05 17:50:01 +01:00
parent 8387d5b22c
commit 2eac5b9908
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/server/trpc/subscriptions.ts
View File

@@ -40,7 +40,6 @@ export const ALL_EVENT_TYPES: DomainEventType[] = [
'agent:account_switched', 'agent:account_switched',
'agent:deleted', 'agent:deleted',
'agent:waiting', 'agent:waiting',
'agent:output',
'task:queued', 'task:queued',
'task:dispatched', 'task:dispatched',
'task:completed', 'task:completed',
@@ -84,7 +83,6 @@ export const AGENT_EVENT_TYPES: DomainEventType[] = [
'agent:account_switched', 'agent:account_switched',
'agent:deleted', 'agent:deleted',
'agent:waiting', 'agent:waiting',
'agent:output',
]; ];
/** /**

4
docs/server-api.md
View File

@@ -204,13 +204,13 @@ Each procedure uses `require*Repository(ctx)` helpers that throw `TRPCError(INTE
| Procedure | Type | Events | | Procedure | Type | Events |
|-----------|------|--------| |-----------|------|--------|
| onEvent | subscription | All event types | | onEvent | subscription | All event types |
| onAgentUpdate | subscription | agent:* events (8 types) | | onAgentUpdate | subscription | agent:* events (7 types, excludes agent:output) |
| onTaskUpdate | subscription | task:* + phase:* events (8 types) | | onTaskUpdate | subscription | task:* + phase:* events (8 types) |
| onPageUpdate | subscription | page:created/updated/deleted | | onPageUpdate | subscription | page:created/updated/deleted |
| onPreviewUpdate | subscription | preview:building/ready/stopped/failed | | onPreviewUpdate | subscription | preview:building/ready/stopped/failed |
| onConversationUpdate | subscription | conversation:created/answered | | onConversationUpdate | subscription | conversation:created/answered |
Subscriptions use `eventBusIterable()` — queue-based async generator, max 1000 events, 30s heartbeat. Subscriptions use `eventBusIterable()` — queue-based async generator, max 1000 events, 30s heartbeat. `agent:output` is excluded from all general subscriptions (it's high-frequency streaming data); use the dedicated `onAgentOutput` subscription instead.
## Coordination Module ## Coordination Module